talonvoice / beta

Issue tracker for the private Talon Beta
10 stars 0 forks source link

Setting.__bool__ should forward to the underlying value #104

Closed lslunis closed 4 years ago

lslunis commented 4 years ago

Right now, settings are always considered true when coerced to bool:

if some_setting:
  # always executes

It's easy to forget to call .get(), and rather than raising an error, this silently does the wrong thing. Instead, it should either raise an error or behave as if bool(some_setting.get()) was called.

lunixbochs commented 4 years ago

should be fixed in 1467, please confirm

lslunis commented 4 years ago

Confirmed