talonvoice / beta

Issue tracker for the private Talon Beta
10 stars 0 forks source link

zoom eye mouse can't be properly disabled on linux (because no tap) #32

Closed timo closed 4 years ago

timo commented 4 years ago

2020-03-16 03:42:41    IO     zoom_mouse.disable()
2020-03-16 03:42:41    IO   File "/home/timo/build/talon/resources/talon_plugins/eye_zoom_mouse.py", line 47, in disable
2020-03-16 03:42:41    IO     tap.unregister(tap.MCLICK|tap.KEY|tap.HOOK, self.on_key)
2020-03-16 03:42:41    IO AttributeError: module 'talon.tap' has no attribute 'unregister'```

Until linux gets full tap support, either have a try/catch, a check for the "unregister" method, or just putting it at the end of the disable method would improve things.
lunixbochs commented 4 years ago

fixed in 1152 (no I didn't add tap, I just fixed this symptom of not having it)