search

talonvoice / beta

Issue tracker for the private Talon Beta
10 stars 0 forks source link

[Mac] Hiding the command history imgui also hides unrelated help imgui #99

Closed knausj85 closed 3 years ago

knausj85 commented 4 years ago

Setup: v1426 OS X 10.15.6 https://github.com/knausj85/knausj_talon

Steps:

  1. "command history show" -- Command History imgui appears
  2. "help alphabet" -- Alphabet imgui appears
  3. "command history hide" -- Both Command History imgui and Alphabet Help imgui disappear
  4. "help alphabet" -- does nothing, gui_alphabet showing flag is still true before calling show()

History imgui code: https://github.com/knausj85/knausj_talon/blob/d762a609d264b065c165dd97109262bf2915bae4/code/history.py#L33

"command history hide" calls this: https://github.com/knausj85/knausj_talon/blob/master/code/history.py#L55

Alphabet imgui code: https://github.com/knausj85/knausj_talon/blob/d762a609d264b065c165dd97109262bf2915bae4/code/help.py#L66

This does not happen on Windows, from what I can tell.

winni2k commented 4 years ago

I can reproduce this issue on MacOS 10.14.6 running talon v1426.

winni2k commented 4 years ago

This is still an issue on version 1435.

lunixbochs commented 3 years ago

This seems to be a Qt issue :/ I'm definitely only calling hide on the one window, and the other is still being asked to render despite not being visible.

lunixbochs commented 3 years ago

should be fixed in next beta