search

talpor / django-dashing

django-dashing is a customisable, modular dashboard application framework for Django to visualize interesting data about your project. Inspired in the dashboard framework Dashing
BSD 3-Clause "New" or "Revised" License
731 stars 108 forks source link

rolling dashboards by URL parameter #13

Closed torstenfeld closed 9 years ago

torstenfeld commented 9 years ago

this should fix #12 and #11 as described in the issues. I added additions to the documention as well.

mtdb commented 9 years ago

Hi, the code looks good and special thanks for improve the documentation :) Testing I found an error, the variable dashboardSet is not defined (line 91 dashing.js), please check this in order to accept the pull request

mtdb commented 9 years ago

Please check too timeoutForDashboardsSet and activeDashboardName variables in addDashboard method, are not defined in the scope of the function

torstenfeld commented 9 years ago

Hi,But they should be declared in the scope of DashboardSet. But I'll check. :)