search

talpor / django-dashing

django-dashing is a customisable, modular dashboard application framework for Django to visualize interesting data about your project. Inspired in the dashboard framework Dashing
BSD 3-Clause "New" or "Revised" License
731 stars 108 forks source link

Fix/issue 73 #74

Closed nickburlett closed 7 years ago

nickburlett commented 7 years ago

Fixes #73.

Changes dashing dependency loading to continue to attempt to load dependencies past the first dependency if the first dependency was already loaded by some other widget.

This is done by changing the resources to be objects with a src key, to which we add a loaded key (set to true) once it's loaded. If the resource requested is already loaded and there are more options, loadResource continues with the next resource.

This commit also adds a test for the issue, but creating a new widget type in the multiple_dashboards.html javascript. It loads only d3, while the Graph widget loads both d3 and rickshaw. The integration test now checks that both d3 and Rickshaw are defined.

Also reworks the test suite to work with phantom 2.

mtdb commented 7 years ago

thanks for the request and thanks for updating phantom, it is a great improvement