talrey / CreateDeco

Decorative Addon for the Create mod for Minecraft
47 stars 47 forks source link

Zinc Sheets Clash With Crafts & Additions #114

Open Luviam opened 9 months ago

Luviam commented 9 months ago

The Zinc Sheets from Create Deco override the zinc sheets from Crafts & Additions and do not work in their recipes, making things like Electric Motors unobtainable without modifying recipes with another mod.

Forge 1.20.1-47.2.19

Create Deco 1.20.1-2.0.0

awbuckst11181999 commented 8 months ago

Same issue here, this needs to be fixed! Please add a config/ore dict compat!

IHaveNightmares commented 8 months ago

This is an issue I keep getting too. Very difficult when I'm on a server and cant modify the recipes.

exocyt0sis commented 7 months ago

Keeping an eye on this one - I would really like to see it fixed. Thanks!

exocyt0sis commented 7 months ago

The Zinc Sheets from Create Deco override the zinc sheets from Crafts & Additions and do not work in their recipes, making things like Electric Motors unobtainable without modifying recipes with another mod.

Until a bug fix is implemented, do you have any suggestions for a work-around using other mods? From what I understand, data packs only allow you to add new recipes, not alter/change existing ones.

steve-the-player commented 7 months ago

The Zinc Sheets from Create Deco override the zinc sheets from Crafts & Additions and do not work in their recipes, making things like Electric Motors unobtainable without modifying recipes with another mod.

Until a bug fix is implemented, do you have any suggestions for a work-around using other mods? From what I understand, data packs only allow you to add new recipes, not alter/change existing ones.

Try Almost Unified. It's a mod that merges metals and recipes from various mods, fixed the issue for me.

exocyt0sis commented 7 months ago

Try Almost Unified. It's a mod that merges metals and recipes from various mods, fixed the issue for me.

Thanks for the information and the URL. Unfortunately, installing it makes no difference for me (using the latest versions of Create: Deco, Create: Crafts & Additions and Almost Unified - at least not out of the box. If this mod works, it probably needs some fine tuning before you are able to press Zinc ingots again.

HenryAWE commented 7 months ago

The Zinc Sheets from Create Deco override the zinc sheets from Crafts & Additions and do not work in their recipes, making things like Electric Motors unobtainable without modifying recipes with another mod.

Until a bug fix is implemented, do you have any suggestions for a work-around using other mods? From what I understand, data packs only allow you to add new recipes, not alter/change existing ones.

I think the cause of the bug is that the zinc sheet from Create Deco doesn't have a proper "forge:plates/zinc" tag. I use KubeJS to fix this on my server:

// put this JavaScript file in kubejs/server_scripts/
ServerEvents.tags("item", e => {
    e.add('forge:plates/zinc', 'createdeco:zinc_sheet')
})

I'm using KubeJS 2001.6.4-build.114 and Minecraft 1.20. Older KubeJS might use a different API but will be the same in general.

MrRedstoneToGo commented 6 months ago

@talrey Don't use data/createdeco/tags/items/internal/plates/electrum-plate.json. This won't help anyone. Your mod cannot use sheets from other mods (like Crafts and Additions) and your sheets cannot be used in other mods. Instead use for forge version data/forge/tags/items/plates/electrum.json (no "-plate") and for fabric data/c/tags/items/electrum_plates.json (example electrum, could be any metal). This also applies for ingots, nuggets and metal blocks.

MrRedstoneToGo commented 6 months ago

And you only need to tag the items, which are added by Create Deco. All others are tagged by the other mods.

Just tell me if I should go through the trouble of creating a pull request. Last time the developer was faster than me and all the effort was in vain :(

MrRedstoneToGo commented 6 months ago

Pull request is out!!