talsec / Free-RASP-Cordova

Cordova plugin for improving app security and threat monitoring on Android and iOS mobile devices.
https://github.com/talsec/Free-RASP-Community
MIT License
16 stars 4 forks source link

Updated README with instructions on how to install #7

Closed itsnoa04 closed 1 year ago

tompsota commented 1 year ago

Hello @itsnoa04 and thanks for opening your first pull request!

Could you please explain why you would like to add this change?

The freeRASP for Cordova is a Cordova plugin, which is not meant to be used as a typical npm package (it exposes JavaScript interface to native components in a way specific to Cordova, therefore it won't work in web or in React Native apps, for example). Cordova has a special command for adding and managing plugins (via cordova plugin ...), which is the prefferred command for managing Cordova plugins.

Additionally, is there any usecase where cordova plugin add is not sufficient and you need to install the plugin via npm i?

Looking forward to hearing from you.

Tomas, Talsec developer

itsnoa04 commented 1 year ago

The Cordova setup in my workflow required an npm I along with a Cordova plugin add. The Cordova plugin adds work most of the time but it is very hit or miss depending on the package.

PS. Sorry for the late response, was caught up in work.

tompsota commented 1 year ago

Dear @itsnoa04, Thank you for your contribution and the effort you put into the freeRASP. However, after careful consideration, we have decided to decline the merge request. Here's the reasoning behind our decision:

Thank you for your understanding.

Best regards, Tomas, Talsec developer