search

talwat / pokeget-rs

A better rust version of pokeget.
MIT License
102 stars 3 forks source link

Minior's core form shiny sprite is highly inaccurate #11

Open OpenSauce04 opened 3 months ago

OpenSauce04 commented 3 months ago

When attempting to show Minior's shiny sprite, the same colour as the non-shiny version is shown with different shading instead of the expected black core:

OpenSauce04 commented 3 months ago

This appears to be a holdover from the upstream pokesprite repo.

For whatever reason, there is a correct shiny sprite in the same respository with a -gen7 suffix despite not being in the gen 7 folder. Any idea why this is the case?

talwat commented 3 months ago

This appears to be a holdover from the upstream pokesprite repo.

For whatever reason, there is a correct shiny sprite in the same respository with a -gen7 suffix despite not being in the gen 7 folder. Any idea why this is the case?

No idea, but if that's the case then it'll be almost impossible to fix on the pokeget side, since it's not worth forking the whole repo to fix a bug. For now, it'll probably have to be stuck like this, but when they fix it i'll be able to pull the changes into pokeget.

OpenSauce04 commented 3 months ago

In the meantime I have discovered that you can still get the correct sprite by typing out the full correct file name, which works in my case because I'm running from a script.

talwat commented 3 months ago

Yeah, I made pokeget pretty flexible when it comes to how you're actually picking the sprites, so for scripts it should work fine :)

I'll keep this open to remind myself to fix this issue.