search

talwat / pokeget-rs

A better rust version of pokeget.
MIT License
91 stars 3 forks source link

(Minor Complaint) Name of pokemon displayed before sprite. #3

Closed droshux closed 10 months ago

droshux commented 10 months ago

I am using your (very cool) code to show a little picture of my favourite pokemon at the top of every new terminal window and it's working great! However the name of the pokemon was on top of the sprite and it was mildly annoying. What would be ideal would be if that didn't happen, or it was possible to turn off but like the title says this is a super tiny complaint and so you don't need to bother fixing it. :) :)

By the way: this tool is super cool, thanks for making it!

Here's the workaround I used:

pokeget umbreon > /tmp/umbreonTEMP.txt
clear
cat /tmp/umbreonTEMP.txt
rm /tmp/umbreonTEMP.txt

Piping to sed (or anything else similar) won't work here because the name of the pokemon gets written to a different stream.

talwat commented 10 months ago

Hmm, that's a super easy fix, I'm a bit of a dunce for not noticing it earlier. Thanks!

talwat commented 10 months ago

It's actually fixed on my end with pokeget 1.2.4. What version are you using? (pokeget --version)

droshux commented 10 months ago

I'm also using 1.2.4 but the issue still appears... geng

talwat commented 10 months ago

Oh, I misunderstood what you meant. You could try and get it so that you filter out stderr, but I could also make a flag to disable the name. I'll go ahead and do the latter now.

talwat commented 10 months ago

Publishing now...

droshux commented 10 months ago

That's fantastic thank's for the rapid fix :) :) Genuinely appreciate it!

talwat commented 10 months ago

Not a problem :)

Sorry for the misunderstanding earlier.