search

talyssonoc / react-laravel

Package for using ReactJS with Laravel
896 stars 90 forks source link

Added Regex Modifier (PCRE_DOTALL) to ReactServiceProvider->createMatcher #63

Closed awylie199 closed 8 years ago

awylie199 commented 8 years ago

Great project, thanks for sharing it.

I've added the PCRE_DOTALL modifier to the ReactServiceProvider.php createMatcher method to capture new lines (http://php.net/manual/en/reference.pcre.pattern.modifiers.php).

So before, this was failing to be rendered:

    @react_component('Message', [
        'title'=>'My Website Title'
    ])

Very small commit, but I ran the unit tests anyway :) Thanks,

Alex

josecelano commented 8 years ago

:+1:

talyssonoc commented 8 years ago

Great! Thanks for your collaboration :smile: