search

tam17aki / ace-isearch

A seamless bridge between isearch, ace-jump-mode, avy, and helm-swoop.
103 stars 10 forks source link

Add: Evil Support #40

Closed larebsyed closed 4 years ago

larebsyed commented 4 years ago

Adding evil support, Requirese evil-search-module to be isearch

Fix: #33

larebsyed commented 4 years ago

@tam17aki This is my first try, and there might be something missing. I am testing this in my own setup. Please take a look and let me know if you think this can work.

larebsyed commented 4 years ago

bump @tam17aki

tam17aki commented 4 years ago

Thank you very much for pull-req. I will check the contents in this week.

tam17aki commented 4 years ago

I have tested the PR on my environment (Emacs 27.1, MacOS Catalina). It works well. I'll test it some more. Thank you very much!

larebsyed commented 4 years ago

@tam17aki Thank you for the review. I have been using this for a while, there is only one issue that I am facing is that when we search a string that is long enough for swiper. The search string is not stored for a repeating the search. Do you have any idea how to fix that?

tam17aki commented 4 years ago

please let me confirm: have you set (setq ace-isearch-on-evil-mode t) ?

larebsyed commented 4 years ago

@tam17aki Not yet, will do over the weekend. sorry for delays.

larebsyed commented 4 years ago

@tam17aki Did the requested changes, and also fixed the issue. Please review when you can.

tam17aki commented 4 years ago

Thank you! I'll use it for a while to check it out. If there are no problems identified, I will merge it into the master branch.