search

tam7t / droplan

Manage iptable rules for the private interface on DigitalOcean droplets
MIT License
69 stars 12 forks source link

Improved docker image #37

Closed mreithub closed 7 years ago

mreithub commented 7 years ago

I've taken the liberty of rewriting the Dockerfile so that it can be built automatically on docker hub (I've got my own clone of this here in case you're interested).

I've also added a wrapper script (docker-run.sh) that periodically invokes droplan (the interval can be specified using $DO_INTERVAL).

Also, I've added a paragraph about using the docker image to README.md

The example command I've added to README.md should be enough to have the tool restart on reboot, be executed in a 5 minute interval, etc.

Let me know if there's anything you want me to add and/or change.

tam7t commented 7 years ago

I like the entrypoint script and readme updates, but I'm not a fan of release docker images also having all the build tools in them. I would accept this PR if it was just the entrypoint and readme update.

(I've created https://github.com/tam7t/droplan/pull/38 for a more consistent build process, but do not wish docker hub to build the images for me)

mreithub commented 7 years ago

I've updated the pull request.

Personally I trust automatic builds a little more (since then the whole process - from source code to image - is public and reproducible) and am willing to pay the few megs of overhead for that certainty.
If it's ok with you, I'll keep my 'auto-build' version of droplan on Docker Hub then (I'll probably put it into a separate build repo though)

tam7t commented 7 years ago

👍 thanks