search

tamago324 / nlsp-settings.nvim

A plugin for setting Neovim LSP with JSON or YAML files
MIT License
316 stars 18 forks source link

go.buildFlags and go.buildTags are not propagated to gopls #11

Closed crpier closed 2 years ago

crpier commented 3 years ago

Encountered a very minor issue when using nlsp-settings: When using "go.buildFlags": ["-tags=integration"] or "go.buildTags": "integration" (either separately or together), the build tag is not propagated to gopls. However the description states that these will be propagated when gopls.build.buildFlags is not specified.

Created this repo to reproduce the issue: https://github.com/tiannaru/go-is-crazy. The issue is in the file internal/pkg/fileread/fileread_integration_test.go.

I am not really sure whether these should propagate or the description should be updated.

marcomayer commented 2 years ago

@tiannaru could you solve this by now? To me it looks like almost none of the settings specified in https://github.com/tamago324/nlsp-settings.nvim/blob/main/schemas/gopls.json do get used, maybe these are actually vscode settings?

I'm trying to get golangci-lint to work using just gopls but go.lintTool seems to get ignored. Could you figure out how to debug nvim -> lsp -> gopls?