search

tamago324 / nlsp-settings.nvim

A plugin for setting Neovim LSP with JSON or YAML files
MIT License
316 stars 18 forks source link

Local settings #5

Closed tamago324 closed 2 years ago

tamago324 commented 3 years ago

close #4.

tamago324 commented 3 years ago

マージするなら、これも実装する

https://github.com/mattn/vim-lsp-settings/pull/441

meijieru commented 2 years ago

Will this PR be merged soon? It seems very useful.

cweagans commented 2 years ago

Is there anything blocking this that I can help with?

tamago324 commented 2 years ago

@cweagans I'm sorry. It's due to my motivation. I am not motivated because I have to rewrite a lot of code...

cweagans commented 2 years ago

Don't be sorry! That's totally normal. Can I help somehow? Do you just need this redone against HEAD?

tamago324 commented 2 years ago

Yes. That's right. I would also like to apply the https://github.com/mattn/vim-lsp-settings/pull/441 changes. If possible, I would like you to do it for me, is that okay?

cweagans commented 2 years ago

Ah, looks like you beat me to it. Apologies for the delay. I was busy with family the past couple of days. Do you still need https://github.com/mattn/vim-lsp-settings/pull/441 done?

tamago324 commented 2 years ago

No, no, it's not your fault. It's Christmas and it's good to spend time with family :christmas_tree: Your comment has motivated me. Thank you.

Since dangerous settings such as cmd are not configurable in nlsp-settings.nvim, we decided that it was not necessary to include mattn/vim-lsp-settings#441. If you have any problems, please let me know.

cweagans commented 2 years ago

Sounds great! Thanks for getting this across the finish line. This will be very helpful to me!!