search

tamagokun / pomander-wordpress

Wordpress tasks for use with Pomander
http://ripeworks.com/pomander/wordpress.html
MIT License
36 stars 5 forks source link

Replacing all URLs #2

Closed asanger closed 11 years ago

asanger commented 11 years ago

Currently, pomander only replaces URLs that match the exact format of http://{url}. There are many possible forms that a URL can take, though, depending on a number of different variables. The merge should attempt to replace as many formats as possible.

Some examples:

http://www.myurl.com www.myurl.com myurl.com http://myurl.com

asanger commented 11 years ago

Actually, this may be working... will run some more tests.

asanger commented 11 years ago

Okay... I do believe that this could be improved. Every single site that I've tried to use pomander with has required a ton of sed commands to weed out all the different variations of the URL. I'm sure it will be much easier after the initial conversion, but it still worries me, especially when non-devs are making changes to the site.

tamagokun commented 11 years ago

Should we do a replace for just the hostname? Any ideas on how to make this smarter/better?

tamagokun commented 11 years ago

Closing this as it relates to #3 and we don't want to mess with the url structure too much.