search

tamalchowdhury / bankcardsbangladesh

A list of all bank cards in Bangladesh. Created to learn project management and help students get started with #hacktoberfest 2023
https://tamalchowdhury.github.io/bankcardsbangladesh/
5 stars 6 forks source link

add the logos of the bank before the name.... #20

Closed Pritam-2002 closed 1 year ago

Pritam-2002 commented 1 year ago

added the logos of the bank before their name....please review and check the changes ... bank logo

Pritam-2002 commented 1 year ago

@tamalchowdhury please review my code..i had make some changes

tamalchowdhury commented 1 year ago

Hi @Pritam-2002, it would be great if we host these images on the site and not hot linking to 3rd party services. This will make multiple requests and impact the load time.

Please make a new directory /img. Then download all the images in that directory and then link them from the site.

You have to add another commit and it will add to this PR.

Thanks!

Pritam-2002 commented 1 year ago

Ok on it

On Tue, 31 Oct 2023, 09:32 Tamal Anwar Chowdhury, @.***> wrote:

Hi @Pritam-2002 https://github.com/Pritam-2002, it would be great if we host these images on the site and not hot linking to 3rd party services. This will make multiple requests and impact the load time.

Please make a new directory /img. Then download all the images in that directory and then link them from the site.

You have to add another commit and it will add to this PR.

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/tamalchowdhury/bankcardsbangladesh/pull/20#issuecomment-1786404391, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV5DSEXAA5WU4U3IOW4PTXLYCBZ33AVCNFSM6AAAAAA6WRJFVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBWGQYDIMZZGE . You are receiving this because you were mentioned.Message ID: @.***>

Pritam-2002 commented 1 year ago

@tamalchowdhury i had make the necessary changes please review it....

tamalchowdhury commented 1 year ago

Hi @Pritam-2002, just one more change and it will be good to go:

Change the directory name from /table-Images to just /img (remember, we should not have uppercase/lowercase mix in directory names.

Tip: You can search and replace the name and links in VS Code. You can search all, and replace all.

The same goes for the file names. Kindly rename all the file names to be more uniform:

brac-bank.png
city-bank.png
bank-asia.png
eastern-bank.jpg

..and so on. All lowercase, no space, and consistent naming scheme.

Thank you for your patience 😊

Pritam-2002 commented 1 year ago

i need to change the images name ....i will change it in few minutes

Pritam-2002 commented 1 year ago

@tamalchowdhury do i change the images name with their specific bank name with no space or i rename them with img-1 ,img-2 in such way??

Pritam-2002 commented 1 year ago

@tamalchowdhury i had made the changes please review it .....