search

tamana-Balkhi / to-do-list

To-do list app, Built with JavaScript and powered by Webpack, that allows users to add delete and update daily activities
2 stars 0 forks source link

Peer-To-Peer-Code-Review #6

Open Kumilachew-g opened 2 years ago

Kumilachew-g commented 2 years ago

You have done great but there are some optional modifications

  1. In the reordering there is an item to be hidden when reordering
  2. In the X button there is text decoration so make it none
  3. It is better to remove unnecessary comments layout.js
mullenlucas commented 2 years ago

Hello Tamana ! giphy

Great code ! One thing that I would kindly suggest, that is a minor observation and just learnt it the other day, is that it is generally preferable to use createElement and create each one with that method, rather than using innerHTML =

So for example, in this line: https://github.com/tamana-Balkhi/to-do-list/blob/1f2a717e6764ebc2c97902fb39b842116595fd42/src/modules/layout.js#L25

The HTML could be generated with createElement. This is generally better for security purposes

Other than that great code Tamana !