tamasfe / aide

An API documentation library
Apache License 2.0
417 stars 70 forks source link

Replace derive_more derives with manual implementations #123

Closed svix-jplatte closed 8 months ago

svix-jplatte commented 8 months ago

Do you want me to try macro_rules! "derives" as an alternative? I think due to all the types here being generic, that would probably only save a few lines and the macro code would be a tad hard to read, so I'd personally prefer this for readability. It's not that much boilerplate IMHO.

Resolves #122.

Wicpar commented 8 months ago

yes wrapping the impls into a macro_rules that takes the identifier of the struct could avoid code duplication. however for two implementations the advantage is negligible. Can you also get the latest updates ? Can you try to sync up with master ? I unfortunately had to force push some commit message changes while you were contributing and it looks like you have an extra commit in your PR