search

tamasfe / taplo

A TOML toolkit written in Rust
https://taplo.tamasfe.dev
MIT License
1.37k stars 115 forks source link

Provide a binary release built on musl-c for taplo-cli #90

Closed yisonPylkita closed 1 year ago

yisonPylkita commented 3 years ago

Right now to use taplo-cli I have to get cargo first and then build taplo-cli. Runime performance-wise it's a good idea but when it comes to an ease of setup it's not that good. Lately I started working more with Docker containers and GH Actions with a variety of Linux distributions on it and using taplo there to lint my tol files is quite problematic. What I'd like to see is a pre-built release of taplo-cli I can download from this page. I think x86_64-unknown-linux-musl target will suite this purpose best. I see there is a GitHub Action to automate such process - https://github.com/marketplace/actions/automatic-releases

Would you be interested in such a feature?

tamasfe commented 3 years ago

Definitely! The only reason Taplo doesn't have prebuilt binaries is that I didn't take the time to set them up.

That being said, I don't have a lot of time right now either, so PRs are welcome!

yisonPylkita commented 3 years ago

I started work on this here. For every new tag prefixed v GH Action will compile taplo-dummy with x86_64-unknown-linux-musl target and will attach compiled application as a zip to releases page To not mix this with your existing workflow I would see this as a new workflow file in .github/workflows Is this good enough for a PR?

tamasfe commented 3 years ago

Thanks!

Looks good so far, just a few things: