tamasmeszaros / libnest2d

2D irregular bin packaging and nesting library written in modern C++
GNU Lesser General Public License v3.0
315 stars 104 forks source link

Non-convex Nesting #16

Open acadbrinkman opened 4 years ago

acadbrinkman commented 4 years ago

Hi,

In the readme it is mentioned that non-convex nesting will be added to the library. Do you have any estimation of when this is ready, if you are working on it? If you are not planning to work on it, do you have an estimation on what needs to be added to include the non-convex nesting?

tamasmeszaros commented 4 years ago

Hi! There is no estimate currently, this heavily depends on the parent project (PrusaSlicer) roadmap. The feature became low priority in the meantime. In fact, I should change the text of the initial readme as it doesn't really reflect the reality anymore.

As to the estimate of time to do it, that is very hard to say even if only I was involved, it would certainly take months of work. What needs to be added is a robust no-fit polygon algorithm implementation. If you really need that, you might get one from another library like CGAL. I did not test if there is a suitable one and didn't found any open source alternative. The integration with this library would also be non-trivial for a contributor, but achievable by specializing the nfp algorithm templates.

kallaballa commented 3 years ago

I'd like to bring to your attention that I've finally put the necessary work into libnfporb to make it robust. There are still issues remaining: https://github.com/kallaballa/libnfporb/issues but they are rare and not critical. Also floating-point and arbitrary precision both yield the same result in the tests, though that parity might break with a mix of very small and very large geometries.

tamasmeszaros commented 3 years ago

Hi @kallaballa ! I'll surely try out integrating the new version. It will take some time for me to get to it though.

kallaballa commented 2 years ago

Maybe I could do it? Could you provide some hints?