tambetm / gym-minecraft

Minecraft environment for Open AI Gym, based on Microsoft's Malmo.
277 stars 29 forks source link

Malmo version mismatches between various parts in the project #10

Open postuur opened 7 years ago

postuur commented 7 years ago

Hey, I've been trying now to get the docker for gym-minecraft, working as well as the agent code on another docker. There's been several problems with the schema versions between the various parts of this pipeline: The docker is using version Malmo's 0.18.0, while some installations of minecraft-py have 0.19.0 and in the Malmo's own project there's already a 0.21.0 out. Currently, I've managed to fix a few of these mismatches by editing for example the Dockerfile, or pulling my own versions of Malmo, but each setup.py (plus some locations elsewhere) seems to be supplying their own hard-coded version numbers.

Is there some way to change the versions all at once in planning, or already existing somewhere?

-J

postuur commented 7 years ago

Actually, I found one of these in Malmo-0.21.0 releases, where it says in the malmo.build.sh that: "wget https://github.com/Microsoft/malmo/releases/download/0.19.0/${packagename}.zip"

Related to this, the docker gave this error message when I was trying to connect to it with an agent: [Thread-21/INFO] [STDOUT]: [com.microsoft.Malmo.Client.ClientStateMachine$1:reply:428]: REPLYING WITH: MALMOERRORVERSIONMISMATCH (Got 0.19.0, expected 0.21.0 - check your path for old versions of MalmoPython/MalmoJava/Malmo.lib etc)

tambetm commented 7 years ago

AFAIK, minecraft-py and Docker images both use 0.18.0. Either minecraft-py35-ubuntu1604 or minecraft-py34-ubuntu1404 might be accidentally using 0.19.0, but this hasn't resulted in any compatibility problems for me.

Sorry, haven't had time to upgrade to 0.21.0, but feel free to submit a PR! Keeping this open till then.