search

tameemsafi / typewriterjs

A simple yet powerful native javascript plugin for a cool typewriter effect.
https://www.npmjs.com/package/typewriter-effect
MIT License
2.49k stars 221 forks source link

`deleteSpeed` does not get propagated to React component #65

Closed MartinSeeler closed 4 years ago

MartinSeeler commented 4 years ago

It seems that the deleteSpeed property is missing / not used in the React component. Is this on purpose or just a bug?

dishcandanty commented 4 years ago

Seems like the property just needs to be added here: https://github.com/tameemsafi/typewriterjs/blob/master/src/react/Typewriter.js#L50

Missing delete speed from the forEach loop

.deleteAll(this.options.deleteSpeed);
dishcandanty commented 4 years ago

Was able to fix by manually patching the deleteSpeed. PR above.

tameemsafi commented 4 years ago

@MartinSeeler Can you confirm if it has been fixed using v2.13.1 as the PR above by @dishcandanty is now merged?

MartinSeeler commented 4 years ago

@tameemsafi Yes, after upgrading to 2.13.1 the deleteSpeed can be changed. @dishcandanty thx for the fix