Changing regex to allow for ";" in properties object

tamentis / cartman

Command line Trac tools

http://tamentis.com/projects/cartman/

ISC License

22 stars 10 forks source link

Changing regex to allow for ";" in properties object #7

Closed joshstrange closed 10 years ago

joshstrange commented 10 years ago

Our Trac install had an item in the requirements object that contained a ";" which broke this tool. The change I made fixes that for us. Thanks!

tamentis commented 10 years ago

I don't think this is a robust way to fix this issue; this regex would catch any semi-colon on the page, not just at the end of the property line. Also, this broke the test suite. I pushed a similar fix and added a test for your case, let me know how it goes.

joshstrange commented 10 years ago

@tamentis I'm sorry, I didn't even notice the test suite or I would have run that, I just threw together something quick so that I could get it working. Thank you very much for pushing this fix!