search

tamino-martinius / node-ts-dedent

TypeScript package which smartly trims and strips indentation from multi-line strings
MIT License
162 stars 8 forks source link

Publish package in ESM module format in addition to CommonJS #19

Closed eirslett closed 3 years ago

eirslett commented 3 years ago

Hey! I'm trying to build Storybook (which uses this module!) with Esbuild and ESM modules. I had a problem because this package exposed dist/index.js as a module, but it's not in ESM format. So I made this simple PR that double-compiles TypeScript into both CommonJS and ESM. How does it look?

codecov-io commented 3 years ago

Codecov Report

Merging #19 (1e8d418) into master (1abbfc1) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           19        19           
  Branches         4         4           
=========================================
  Hits            19        19

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1abbfc1...1e8d418. Read the comment docs.

tamino-martinius commented 3 years ago

Awesome - thanks for contributing - will have a deeper look and release changes later this week

tamino-martinius commented 3 years ago

@eirslett sorry for the huge delay - but finally got it merged Thanks a lot 🙏