tamland / airsonic-refix

Modern web UI for Subsonic compatible servers
GNU Affero General Public License v3.0
304 stars 48 forks source link

Add Files #108

Closed archekb closed 1 year ago

archekb commented 1 year ago

I have many music collections in folders and I like my structure of music. That's why I add files browser. image

ToxicFrog commented 1 year ago

I've been testing this locally and it works pretty nicely.

Features it's missing that I'd like to see someday:

I don't think any of those should be blockers for merging it, though.

ToxicFrog commented 1 year ago

Just realized it also doesn't show metadata -- just filenames.

archekb commented 1 year ago

Correct, it's not shows meta data, only filenames, it's not a mistake, if you need metadata you can add files to playlist and play it or get tracks from collection. My library building on filenames (on many files metadata are not correct or empty, but filenames are correct). Now I preparing client settings for Airsonic refix and when (if) files commit will be merged, I can add this (show meta information on Playing section) to the client settings.

ToxicFrog commented 1 year ago

In my case the tags are usually correct, they just aren't sufficient in themselves for useful navigation (the directory tree is generated partially from data that lives outside the tags). The exception is generally files that don't support ID3 or Vorbis tags at all, like most tracker formats.

Anyways, I've hacked file metadata display into my local version; it's really messy -- first time working in typescript -- but it seems to be working ok. I think that's sufficient that I can deploy it on my server while I wait for official support. Thank you for writing this!

Glandos commented 1 year ago

What's the plan with xonic-ui? I think that this PR could have been left open…

archekb commented 1 year ago

I have a many plans for xonic-ui:

I wanted make it in airsonic-refix, but owner of this repo do not need it. I was starts all new branches from airsonic-refix master branch (for do not makes a conflict), but at the moment it was have many incompatible changes. I can't add new features, because old do not merged, and I makes a decision to make a fork.

If you want to test or help, welcome.

PS If you need a files in airsonic-refix, code available on files change tab, you can copy it and reopen this PR.

archekb commented 1 year ago

@tamland Sorry bro, I was wrong, when you close radio stations I was think you do not need any new features to your repo and I make a fork. My bad. Only on last week I saw, you apply the Radio Stations changes. But it was very slow. I can't make a new, because many old code not merged. You can reopen any my PR and get features which you want, if you need.