search

tamland / python-tidal

Python API for TIDAL music streaming service
GNU Lesser General Public License v3.0
402 stars 109 forks source link

Add typings for Session #196

Closed arusahni closed 10 months ago

arusahni commented 1 year ago

This depends on #191. Commits should be reviewed independently as this diff includes changes from that PR, too.

This brings the Session module in line with typings, and cleans up some now-redundant casts. Because mypy is no longer choking on the Session, some issues with existing annotations elsewhere in the project were revealed. This cleans them up, too.

$ poetry run mypy --strict tidalapi/
Success: no issues found in 12 source files

Fixes #137

tehkillerbee commented 1 year ago

@2e0byo I've just put you as a reviewer on this PR. Feel free to put me as a reviewer, if you are busy rn.

2e0byo commented 1 year ago

I'll try to go through this weekend. @arusahni as always thanks for the hard work

arusahni commented 11 months ago

Howdy - I wanted to bump this in case it fell between the cracks.

tehkillerbee commented 11 months ago

@arusahni Sorry, I will take a look asap.

tehkillerbee commented 10 months ago

@arusahni Sorry for the lack of activity on this PR. I will do some tests on this and get it merged in one of the next few days.

tehkillerbee commented 10 months ago

Works with the latest changes. Some fixes are needed to the tests, but probably unrelated to this PR, as the tests have been broken for some time. I will also update the pyproject.toml since we have a couple of new dependencies added but I will do this in a separate PR.