search

tamle-dev / google-crawler

Google search result crawler
0 stars 0 forks source link

Using a UI template #16

Open olivierobert opened 3 years ago

olivierobert commented 3 years ago

The goals of the code challenge is to best assess the technical skills of a developer. The expectations on using libraries/gem is expected. However, the expectation is also to have a fair amount of custom code made by the applicant. This is not the case in this submission as all CSS and JS from a third-party template stored in public/crm:

https://github.com/tamle-dev/google-crawler/blob/e96384b0aa9a5473f7206c7f5c16aab5177f002e/app/assets/javascripts/user.js#L5-L16

https://github.com/tamle-dev/google-crawler/blob/e96384b0aa9a5473f7206c7f5c16aab5177f002e/app/assets/stylesheets/user.css#L2-L5

Many files inherited from the template have also been left behind:

image

The same can be said for dependencies such assets for calendar, dopzone, etc are not even used.

💡 The code seems to be an older version of this theme: https://preview.keenthemes.com/metronic8/demo5/index.html)

tamle-dev commented 3 years ago

This is my fault, I was too focused on the logic of the challenge. I will refactor and remove unused files as soon as possible. Thanks for your feedback.