Related to excess heat factor code

[GanarajDalal]

Good Evening once again Following code worked for --dailyonly, --tx90pc-daily, --tn90pc-daily ehfheatwaves -x"/home/ganaraj/Documents/data/Tmax_1951_2020_13Jan_ch.nc" -n"/home/ganaraj/Documents/data/Tmin_1951_2020_chunit.nc" -m"/home/ganaraj/Documents/data/Tmax_mask_1951_2020_13Jan_ch.nc" --vnamex=tmax --vnamen=tmin --vnamem=mask --vnamet=time --base=1951-2020 --dailyonly

But it is not working for yearly output like --tx90pc, --tn90pc,-v ehfheatwaves -x"/home/ganaraj/Documents/data/Tmax_1951_2020_13Jan_ch.nc" -n"/home/ganaraj/Documents/data/Tmin_1951_2020_chunit.nc" -m"/home/ganaraj/Documents/data/Tmax_mask_1951_2020_13Jan_ch.nc" --vnamex=tmax --vnamen=tmin --vnamem=mask --vnamet=time --base=1951-2020--tx90pc

I am not getting yearly output

[tammasloughran]

I can't replicate your problem.

Maybe it has something to do with your data? Can you try running it on the example data set in the tests/ folder?

cd tests
ehfheatwaves -x climpact2.sampledata.gridded.1991-2010.nc -n climpact2.sampledata.gridded.1991-2010.nc --vnamex=tmax --vnamen=tmin --base=1991-2010 --tx90pc -v

You should see something like this:

ehfheatwaves -x climpact2.sampledata.gridded.1991-2010.nc -n climpact2.sampledata.gridded.1991-2010.nc --vnamex=tmax --vnamen=tmin --base=1991-2010 --tx90pc -v
/home/lou059/envs/heatwaves/lib/python3.8/site-packages/ehfheatwaves/getoptions.py:79: UserWarning: You didn't specify a land-sea mask. It's faster if you do, so this might take a while.
  if not options.maskfile: warnings.warn(warnmsg, UserWarning)
Loading data
Calculating percentiles
Loading data
Caclulating definition
Calculating yearly aspects
Saving

ls -l
total 122572
drwxrwxr-x 2      4096 Jan 28 10:16 ./
drwxrwxr-x 7      4096 Jan 27 16:32 ../
-rw-rw-r-- 1  40149812 Aug 25 12:00 climpact2.sampledata.gridded.1991-2010.nc
-rw-rw-r-- 1    437856 Aug 25 12:00 hwdata.npy
-rwxrwxr-x 1     16715 Jan 27 16:32 run_tests.py*
-rw-rw-r-- 1   1829709 Jan 28 10:20 tx90pct_heatwaves____yearly_summer.nc

[tammasloughran]

But it is not working for yearly output like --tx90pc, --tn90pc,-v ehfheatwaves -x"/home/ganaraj/Documents/data/Tmax_1951_2020_13Jan_ch.nc" -n"/home/ganaraj/Documents/data/Tmin_1951_2020_chunit.nc" -m"/home/ganaraj/Documents/data/Tmax_mask_1951_2020_13Jan_ch.nc" --vnamex=tmax --vnamen=tmin --vnamem=mask --vnamet=time --base=1951-2020--tx90pc

I just noticed there is a missing space in between --base=1951-2020 and --tx90pc. But even with the mistake, it should have created a yearly EHF file.