search

tammoippen / plotille

Plot in the terminal using braille dots.
MIT License
398 stars 17 forks source link

Accept `datetime.date` as X input #26

Closed acarl005 closed 4 years ago

acarl005 commented 4 years ago

For time series plotting, python's built in datetime.datetime class is much appreciated! However, sometimes datetime.date is more convenient. Could these be accepted as input as well?

tammoippen commented 4 years ago

Hi @acarl005 , Thanks for the suggestion. I guess, it will be done by creating and registering a formatter and converter to InputFormatter, similar to the datetime converter/formatter. Are you interested in providing a PR? Otherwise I will look into this, but it might take some weeks for me to find the time.

acarl005 commented 4 years ago

Sure! I'd be happy to add. Can you show me how to trigger the test suite?

tammoippen commented 4 years ago

Sure! Clone and install the repository. See poetry.

$ cd into/cloned/project/folder
$ poetry install
$ poetry shell
$ pytest -s -vvv
tammoippen commented 4 years ago

You can also look at the ci script: https://github.com/tammoippen/plotille/blob/master/.circleci/config.yml

Espacially commands: tester:

acarl005 commented 4 years ago

Thanks! Check out #28 and see what you think of this implementation.

tammoippen commented 4 years ago

Closing as of #28