search

tammoippen / plotille

Plot in the terminal using braille dots.
MIT License
398 stars 17 forks source link

Fix color codes #42

Closed tammoippen closed 3 years ago

tammoippen commented 3 years ago

Later terminals added the ability to directly specify the "bright" colors with 90–97 and 100–107.

I got this mixed with foreground colors having old style, eg 1;31; for bright red, and background with new style, e.g. 101; for bright red.

This PR introduces separate names for each, e.g. bright_red for the later style and bright_red_old for the old style.

Also a small breaking change in Dots, Canvas and Figure:

codecov[bot] commented 3 years ago

Codecov Report

Merging #42 (88caad4) into master (4d0071d) will increase coverage by 0.13%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   97.06%   97.19%   +0.13%     
==========================================
  Files           9        9              
  Lines         987      998      +11     
  Branches      170      172       +2     
==========================================
+ Hits          958      970      +12     
  Misses         10       10              
+ Partials       19       18       -1
Flag Coverage Δ
unittests 97.19% <100.00%> (+0.13%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plotille/_canvas.py 100.00% <100.00%> (ø)
plotille/_colors.py 100.00% <100.00%> (+1.25%) :arrow_up:
plotille/_dots.py 98.57% <100.00%> (+0.04%) :arrow_up:
plotille/_figure.py 96.75% <100.00%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d0071d...88caad4. Read the comment docs.