Pre-Launch Theme Testing

[aaclayton]

Here are some testing goals for the new theme:

1) Register a new user account. You won't be able to "activate" the account on your local test site, since this requires email validation. You can use the plugin "BuddyPress Pending Activations" - http://wordpress.org/plugins/buddypress-pending-activations/ to manually activate pending accounts.

2) Fully configure a user profile. Try all sorts of different race/class/faction combinations. Play around with signature and biography formatting options. Change your email address and password. Change your notification preferences.

3) Browse through articles. Look at author and category archives. Play around with commenting on front-page articles. Edit and delete article comments. Report article comments.

4) Create new forum posts, reply to them, moderate them. Report forum posts.

5) Perform merge, split, move, and edit operations on multiple forum posts.

6) Add other users as friends, send public and private messages. Issue another user an infraction, and post moderator notes on their profile. Send private messages to a group of users.

7) Post status updates on your user profile, and the main sitewide activity feed.

8) Use the activity feed to filter for all sorts of different content options.

9) Use the members directory to browse the new users you have created and sort them on different criteria.

10) Submit a new guild using the guild submission form.

11) Create some new guilds using the guild creation form.

12) Fully customize and configure guild options using the administration panels.

13) Join a guild on multiple user accounts. Play around with guild activity feeds, invitations, status updates, and private forums.

14) Browse through multiple guilds on the guild directory. Use sorting and filtering options.

15) Submit a contact form.

16) Use the advanced search form to search for different combinations of results.

17) Try to break the login system.

18) Experiment with the admin bar and navigation menu. Make sure all the links work. Send different types of notifications back and forth between two user accounts. Manually clear notifications.

19) Create new forum posts and give them "This Thread Rocks" votes on different user accounts. Experiment with the "Best-Of Topics" listing.

20) Try to unlock some profile badges.

21) Try to break avatar uploading.

I may think of more...but this is enough for a couple days of testing I think. For each item, think about layout, design, and usability. Is there some javascript that we could add to enhance the user experience? Does the CSS layout look a bit wierd in places? Is it hard to figure out how to do any of the above items? I know you are less familiar with the theme than I am, so use that to your advantage. Let me know what trips you up, or doesn't make sense.

[jaspervalero]

Great I'll start working my way through it as soon as you give the word to begin testing.

As far as 1) goes I can validate email with my dev environment. I'll try validating both ways though for the sake of user testing.

[aaclayton]

Go ahead and start as soon as you have time. I'd just say to make sure to pull down recent commits every time before you start as I'm going to be making a lot of little updates this week.

[jaspervalero]

Just now pulled down latest version and getting the following:

Looks like the class BP_Groups_Meta_Filter is defined twice?

1) src/apocryphatwo/extra-stuff/bp-custom.php:197 2) src/apocryphatwo/library/extensions/buddypress.php:1024

[aaclayton]

Hey Jasper,

I've deprecated the use of the bp-custom file, you can safely delete it. See the commit "Improved BuddyPress and bbPress Initialization" from October 6 for more details.

[jaspervalero]

Ok will do.

I'd suggest wrapping all class definitions with the following to add more resiliency to the code:

// Define class only if not defined already
if ( ! class_exists( 'Class_Name' ) ) {
    // Class definition here...
}

[aaclayton]

Yeah, I recognize the value of that code snippet...but frankly, if anyone ever tries to re-define any of these core classes they probably deserve a fatal error for their trouble.

On Tue, Oct 8, 2013 at 3:37 PM, Jasper Valero notifications@github.comwrote:

Ok will do.

I'd suggest wrapping all class definitions with the following to add more resiliency to the code:

// Define class only if not defined already if ( ! class_exists( 'Class_Name' ) ) { // Class definition here... }

— Reply to this email directly or view it on GitHubhttps://github.com/tamriel-foundry/apocrypha/issues/28#issuecomment-25933693 .

[jaspervalero]

Well TBH someone trying to redefine an existing class via writing another class is a very rarely the use case for the above snippet. The use case is for a scenario just like what happened with me. Something gets moved around or a file is copied somewhere, but another version remains elsewhere.

In all things code... resiliency should be implemented. Be careful rationalizing in a vacuum. It will compromise your coding technique and cause you to build up what I call "code debt". Coding improves with practice, so always practice the best way of doing things regardless the size or scope of the project.

P.S. It's one thing if you don't know about a technique, which I realize you probably didn't. But now you do. ;)

[aaclayton]

Fair enough. Do you anticipate having any time around TS tonight or tomorrow evening?

On Tue, Oct 8, 2013 at 3:46 PM, Jasper Valero notifications@github.comwrote:

Well TBH someone trying to redefine an existing class via writing another class is a very rare use case for the above snippet. The use case is for a scenario just like what happened with me. Something gets moved around or a file is copied somewhere, but another version remains elsewhere.

In all things code... resiliency should be implemented. Be careful rationalizing in vacuum. It will compromise your coding technique and cause you to build up what I call "code debt". Coding improves with practice, so always practice the best way of doing things regardless the size or scope of the project.

— Reply to this email directly or view it on GitHubhttps://github.com/tamriel-foundry/apocrypha/issues/28#issuecomment-25934179 .

[jaspervalero]

Honestly, TBD. Trying hard though. I can swing a Skype IM if that works for you?

[aaclayton]

yeah, Skype is always useful. I'm on all the time if I'm home.

On Tue, Oct 8, 2013 at 5:28 PM, Jasper Valero notifications@github.comwrote:

Honestly, TBD. Trying hard though. I can swing a Skype IM if that works for you?

— Reply to this email directly or view it on GitHubhttps://github.com/tamriel-foundry/apocrypha/issues/28#issuecomment-25938831 .

[jaspervalero]

1) Register a new user account. You won't be able to "activate" the account on your local test
site, since this requires email validation. You can use the plugin "BuddyPress Pending 
Activations" - http://wordpress.org/plugins/buddypress-pending-activations/ to manually activate 
pending accounts.

[Issue] On page load - issue related to i1.wp.com, avatar from guild widget in sidebar:

[Issue] When trying to input text into registration form, text is unreadable as background too dark:

[Question] Are we sure about this "TAMRIEL FOUNDRY IS NOT"? Could be a premiere feature down the road.

[Issue] Duplicate "Terms of Registration"

[Success] Able to submit form and create user.

[Success] Able to activate user via email verification and BuddyPress pending activations.

[jaspervalero]

2) Fully configure a user profile. Try all sorts of different race/class/faction combinations. 
Play around with signature and biography formatting options. Change your email address and 
password. Change your notification preferences.

[Success] Able to access profile

[Issue] Two input fields for name on edit profile > character info, if last/first then should label as such

[Success] Updated profile multiple times using different rase/class/faction combos.

[Success] Able to change email and password. Able to logout and log back in with new password.

[Success] Able to change notification preferences.

[Issue] Same dark BG on text input on edit profile form:

[jaspervalero]

3) Browse through articles. Look at author and category archives. Play around with commenting on 
front-page articles. Edit and delete article comments. Report article comments.

[Success] Able to browse articles.

[Success] Able to view author and category archives.

[Issue] Post count progress bar pushes right up against bottom of profile box on author page

[Success] Adding comment. Editing comment. Deleting comment.

[Question] After posting a comment to an article, form rolls up and post rolls down. Form is no longer displayed until user refreshes the page. Is that desired functionality? Just thought I'd ask.

[Issue] Slight jumpiness right at the end of deletion animation slide up/down. Minor issue.

[Success] Reported comment.

[jaspervalero]

4) Create new forum posts, reply to them, moderate them. Report forum posts.

[Issue] Dark BG for text input on new post form, I'm guessing this is more of a sitewide issue. Again will dig into this after I go through list.

[Success] Able to make new post.

[Question] Similar to comment question in #3 above. After posting a reply to thread, form rolls up and post rolls down. Reply form is no longer displayed until user refreshes the page.

[Issue] Topic tag box shows up on reply form. I believe this should be just for new posts.

[Success] Able to utilize moderation tools.

[Success] Reported post.

[Issue] 404 on "Best Weekly Topics"

[jaspervalero]

5) Perform merge, split, move, and edit operations on multiple forum posts.

[Success] Able to moderate multiple forum posts without issue.

[Lies] Split and merge actually can be undone, by doing the opposite. LOL

[aaclayton]

Hey Jasper, thanks for this progress. Some responses (numbered by testing task)

2) The two name fields are First Name / Last Name... it might make more sense to go with a single name field, but the two fields are already provided innately by WordPress, so I figured I'd just adapt them.

3) Added some bottom margin to the user block on author archive pages in case the biography is shorter than the user block.

3) The form roles up to forcibly prevent double-posting. It's a deliberate (and perhaps a bit crude) trick to stop people from doing that.

4) The "Topic Tags" field shows up for you always because you are a site admin. It allows admins and mods to change the tags associated with a topic whenever they reply. This is actually an intended feature. Most users won't see this field.

4) The "Best Weekly Topics" page uses a custom page template, you'll need to create a page in the dashboard and assign it the best-of template.

4) Not an issue you specifically mentioned...but it looks like the button images for your TinyMCE aren't showing up?

5) I suppose it can be reverse-engineered...but there's no direct "undo" button, I could re-word the warning to be a little less scary though.

[jaspervalero]

6) Add other users as friends, send public and private messages. Issue another user an
infraction, and post moderator notes on their profile. Send private messages to a group of users.

[Issue] Unable to successfully accept friend request. When click on accept, it seems to work. But when I switch to "Friendships" tab no members found and "Request" tab shows 1 invite again. Tried several times, always same result.

[Issue] Compose tab hides the compose form in sorts. I feel like it is an action that will be taken a lot and should be a part of the default UI or more of an affordance. Although it is nice how it is a button affordance on the message flyout menu.

[Issue] Not sure how the send admin notice to all users works. I tried sending one with no recipient set thinking it would automatically send to all with the box checked. However did not appear to send anything. I'd also recommend moving that checkbox up to the right of recipient field.

[Success] Able to issue infractions.

[Success] Able to create moderator notes.

[jaspervalero]

7) Post status updates on your user profile, and the main sitewide activity feed.

[Success] Able to post update to profile.

[Success] Able to post update on/via sitewide activity feed.

[jaspervalero]

8) Use the activity feed to filter for all sorts of different content options.

[Success] All filters seem to be working.

[jaspervalero]

9) Use the members directory to browse the new users you have created and sort them on different
criteria.

[Success] All filters on members directory appear to work.

[jaspervalero]

10) Submit a new guild using the guild submission form.

[Issue] On step 3 of creating a new guild, seems like should be checkbox next to, "Yes. I want..."

[Success] Was able to successfully create guild.

[jaspervalero]

11) Create some new guilds using the guild creation form.

[Question] Is this one a duplicate of 10) or am I missing something?

[jaspervalero]

12) Fully customize and configure guild options using the administration panels.

[Success] These same panels are part of the new guild creation process. I did test changes via these panels after guild creation though and everything seems to work.

[aaclayton]

[Issue] Unable to successfully accept friend request. When click on accept, it seems to work. But when I switch to >"Friendships" tab no members found and "Request" tab shows 1 invite again. Tried several times, always same >result.

Worked fine for me...I guess we'll need to look more at this. Can you figure out why it's failing on your end? Is it an issue in the JS/AJAX or an issue with the PHP?

[Issue] Compose tab hides the compose form in sorts. I feel like it is an action that will be taken a lot and should >be >a part of the default UI or more of an affordance. Although it is nice how it is a button affordance on the >message >flyout menu.

I think most of the time people will be taken directly to the compose form by using the "Private Message" link on someone's user profile.

[Issue] Not sure how the send admin notice to all users works. I tried sending one with no recipient set thinking it >would automatically send to all with the box checked. However did not appear to send anything. I'd also >recommend moving that checkbox up to the right of recipient field.

Sitewide notices aren't an included component at this point in time. Site admins are the only ones that see this checkbox, so I'm content to leave as-is for now.

[Issue] On step 3 of creating a new guild, seems like should be checkbox next to, "Yes. I want..."

You'll need the bbPress core hack which I mentioned earlier for this checkbox to show up

[Question] Is this one a duplicate of 10) or am I missing something?

There's two "new guild" forms. One that site admins get that actually performs the function of creating a new guild: tamrielfoundry/groups/create. The other is a custom page template which provides a form for users to fill out and "submit" their guild for moderator approval. You'll need to create a page in the backend and assign it the "Submit Guild" template: tamrielfoundry/submit-guild/

[aaclayton]

In your testing thus-far, do you have any general thoughts about the overall layout or feel of the theme, apart from the does it work/not work checks?

[aaclayton]

Have you had the chance to make any further progress with some of this testing? What is your availability looking like for the next 3 days? I would really like to make sure everything is squared away for Sunday.

[jaspervalero]

11) 11) Create some new guilds using the guild creation form.

[Success] After you explained the difference, I was able to successfully complete #10 and #11.

12) Fully customize and configure guild options using the administration panels.

[Success] I ran into no issues on the guild admin panels.

13) Join a guild on multiple user accounts. Play around with guild activity feeds, invitations, status updates, and private forums.

[Success] Able to join guild on multiple accounts.

[Success] Guild activities, invitations, updates seem to work.

[Issue] Custom group file in place but still no check box:

[Issue] Group Forum selection dropdown exposes main forum threads to assign to a group. Should only show custom group forums. Perhaps this is an admin feature, but either way it would be a lot safer if we removed our actual TF forums from the dropdown.

[Issue] Cannot test group forums. Unable to see checkbox, also unable to set via Group Forum. When you click save settings it resets back to "(No Forum)".

14) Browse through multiple guilds on the guild directory. Use sorting and filtering options.

[Success] Able to browse through the guild directory using all sorting/filtering options and no issues seen.

15) Submit a contact form.

[Success] Able to successfully submit contact form.

16) Use the advanced search form to search for different combinations of results.

[Issue] I saw your comment and know you just wanted to get this done, but consider this confirmation that advanced search is not up to snuff as of yet. Will need some TLC after launch. At the very least need to cluster fields for different search types and add more spacing and padding. Everything looks clumped and because everything is displayed at once there is duplication of fields.

[Issue] Search form does not seem to work. I'll have another look at this when I get home though. Not seeing any errors, search button seems to do nothing.

[aaclayton]

Hey jasper,

Thanks for continuing with this. I only have a minute before a meeting, but regarding adv search, you are looking at the wrong thing i think. Looks like you are referencing your old in-progress template instead of the new form

Sent from my iPhone

On Oct 11, 2013, at 1:19 PM, Jasper Valero notifications@github.com wrote:

11) 11) Create some new guilds using the guild creation form. [Success] After you explained the difference, I was able to successfully complete #10 and #11.

12) Fully customize and configure guild options using the administration panels. [Success] I ran into no issues on the guild admin panels.

13) Join a guild on multiple user accounts. Play around with guild activity feeds, invitations, status updates, and private forums. [Success] Able to join guild on multiple accounts.

[Success] Guild activities, invitations, updates seem to work.

[Issue] Custom group file in place but still no check box:

[Issue] Group Forum selection dropdown exposes main forum threads to assign to a group. Should only show custom group forums. Perhaps this is an admin feature, but either way it would be a lot safer if we removed our actual TF forums from the dropdown.

[Issue] Cannot test group forums. Unable to see checkbox, also unable to set via Group Forum. When you click save settings it resets back to "(No Forum)".

14) Browse through multiple guilds on the guild directory. Use sorting and filtering options. [Success] Able to browse through the guild directory using all sorting/filtering options and no issues seen.

15) Submit a contact form. [Success] Able to successfully submit contact form.

16) Use the advanced search form to search for different combinations of results. [Issue] I saw your comment and know you just wanted to get this done, but consider this confirmation that advanced search is not up to snuff as of yet. Will need some TLC after launch. At the very least need to cluster fields for different search types and add more spacing and padding. Everything looks clumped and because everything is displayed at once there is duplication of fields.

— Reply to this email directly or view it on GitHub.

[jaspervalero]

Yeah I figured it was something like that. Was interrupted before I could look at it more.

On Friday, October 11, 2013, Andrew wrote:

Hey jasper,

Thanks for continuing with this. I only have a minute before a meeting, but regarding adv search, you are looking at the wrong thing i think. Looks like you are referencing your old in-progress template instead of the new form

Sent from my iPhone

On Oct 11, 2013, at 1:19 PM, Jasper Valero <notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>> wrote:

11) 11) Create some new guilds using the guild creation form. [Success] After you explained the difference, I was able to successfully complete #10 and #11.

12) Fully customize and configure guild options using the administration panels. [Success] I ran into no issues on the guild admin panels.

13) Join a guild on multiple user accounts. Play around with guild activity feeds, invitations, status updates, and private forums. [Success] Able to join guild on multiple accounts.

[Success] Guild activities, invitations, updates seem to work.

[Issue] Custom group file in place but still no check box:

[Issue] Group Forum selection dropdown exposes main forum threads to assign to a group. Should only show custom group forums. Perhaps this is an admin feature, but either way it would be a lot safer if we removed our actual TF forums from the dropdown.

[Issue] Cannot test group forums. Unable to see checkbox, also unable to set via Group Forum. When you click save settings it resets back to "(No Forum)".

14) Browse through multiple guilds on the guild directory. Use sorting and filtering options. [Success] Able to browse through the guild directory using all sorting/filtering options and no issues seen.

15) Submit a contact form. [Success] Able to successfully submit contact form.

16) Use the advanced search form to search for different combinations of results. [Issue] I saw your comment and know you just wanted to get this done, but consider this confirmation that advanced search is not up to snuff as of yet. Will need some TLC after launch. At the very least need to cluster fields for different search types and add more spacing and padding. Everything looks clumped and because everything is displayed at once there is duplication of fields.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/tamriel-foundry/apocrypha/issues/28#issuecomment-26171556 .

[jaspervalero]

Okay well I can access the page but nothing shows up. The part where the form would be is empty. And passing params doesn't seem to help.

[jaspervalero]

17) Try to break the login system.

[Success] Was unable to find issues while trying to break the login system.

18) Experiment with the admin bar and navigation menu. Make sure all the links work. Send different types of notifications back and forth between two user accounts. Manually clear notifications.

[Success] All links working in nav and admin bar.

[Success] Notifications back and forth working fine. Able to manually clear notifications

19) Create new forum posts and give them "This Thread Rocks" votes on different user accounts. Experiment with the "Best-Of Topics" listing.

[Success] Able to successfully cast votes for posts. BTW, big LOL on "This got ugly". Love it man.

[Success] Best topics looks good. I think this will be a really likeable feature. Better than I initially thought.

20) Try to unlock some profile badges.

[Success] Successfully unlocked, TF team, grouped, ER and allegiance badges.

21) Try to break avatar uploading.

[Success] Unable to break avatar uploading. All uploads successful.

[aaclayton]

Thanks for the feedback on some of the other points. So... today is the day (unless we encounter any major issues in the next several hours).

Some stuff is still not finished, and I'm going to be scrambling to get everything ready. I can handle almost everything myself, but it's pretty clear I don't understand what to do with the images that need to be optimized, and I could really use a hand getting that taken care of. IF you have any time today to do that, it would be great, because at the moment our header and background images are too big to launch with (imo).

[aaclayton]

As a follow up to the above, it would be great if you could drop by TeamSpeak at some point to help out with that, if not...no worries. I would prefer you don't do anything unless we are in direct voice communication about it today.

If you can help out in TS during the launch that would be awesome, but if not I'll do my best to downsize hte images some myself.