search

tamriel-foundry / apocrypha

Theme files for Tamriel Foundry
2 stars 1 forks source link

Add automated lint/build/release system #9

Closed jaspervalero closed 11 years ago

jaspervalero commented 11 years ago

Add Grunt tasks for to repo to allow for easier build and release and other tasks that should be automated.

jaspervalero commented 11 years ago

Grunt automation has now been added to the development branch.

aaclayton commented 11 years ago

Jasper... I have to admit. While this Grunt stuff sounds cool, it looks super complicated. I have a bunch of changes that I made this evening, but I guess I can't push them to dev branch yet? I think doing that might wipe out all the grunt stuff, I don't know.

I guess it's a bit late to ask this...but do you think this project is big enough that we really need automated version numbering and stuff? I mean... I realize it's good practice for a large-scale production environment, but it seems kind of like overkill.

aaclayton commented 11 years ago

Ok... having through a bit more about Grunt, I think we should stick with it. It's definitely a system you are familiar with and speak highly of. I was pretty tired last night and I think I just didn't quite understand what was happening. I'll continue uploading my additions, this time to the src directory.

One note, I would like to stick with the full 'library' name as opposed to the shorthand 'lib', just stylistic preference if you don't mind.

jaspervalero commented 11 years ago

I get it may seem complicated at first, it is actually really easy to use as you'll soon see. Now that it is in and the structure is setup the structure will remain the same. Grunt is something I use for anything beyond 1 file projects. Regardless of project size, the Don't Repeat Yourself (DRY) principle is always the way to go. Grunt = DRY. Why manually minify and lint if you can just have it done automatically for you? So really the project is as simple as it was before, all contained within one apocryphatwo folder inside the src/. It just has a beautiful layer around it for automation. But the project still really exists just inside that folder.

Additionally, it is a chance for you to become familiar with a tool that is cutting edge. And you have me to help you learn it. I've even added instructions in the README for setup and use, which is showedcased on the development branch homepage. I always consider size of project before adding tools and resources to it, so 99% of the time if I suggest something it is project size appropriate and just a straight up best practice. :)

In regards to the lib vs library thing. I'm happy to continue using whichever you like. This is after all your baby. The industry standard is lib because it saves file size over the long run, because you can use less chars when referencing it. Not to mention a lot of frameworks and such look for lib or demand it. It will be fine with this project to use library, but only if we change css to cascadingstylesheets and js to javascript. LOL, J/K.

I appreciate you airing your concerns and being straightforward. Ultimately, I'll yield to you on how you want to approach and manage the project. :)

jaspervalero commented 11 years ago

P.S. Now that this is done, I'll be focusing on doing some actual project coding.