search

tamsanh / kedro-great

The easiest way to integrate Kedro and Great Expectations
MIT License
52 stars 14 forks source link

Use dataset_value when _filepath is None #2

Closed akruszewski closed 4 years ago

akruszewski commented 4 years ago

When trying to load InMemoryDataset kedro.io.core.DataSetError: Data for MemoryDataSet has not been saved yet exception is raised. To prevent that dataset_value is used when _filepath is None

tamsanh commented 4 years ago

@akruszewski Gotcha! Maybe instead of using if _filepath is None, we should do an explicit check for a MemoryDataSet. I think that'll be a robust way to get where we want.

akruszewski commented 4 years ago

@tamsanh That's definitely better idea than solution in this PR. I will update this PR today with that change.

akruszewski commented 4 years ago

@tamsanh ready for review.

tamsanh commented 4 years ago

Looks great! I'll merge and rerelease. It works for your use case, right? @akruszewski

akruszewski commented 4 years ago

Yes, it was tested with it. Thanks! @tamsanh

akruszewski commented 4 years ago

I just figure out, that I didn't used version from this PR during tests and introduced bug (removed dataset_path). Sorry... @tamsanh

tamsanh commented 4 years ago

@akruszewski No worries, I caught the bug, and fixed the code in the latest release