search

tamzinblake / js3-mode

A chimeric fork of js2-mode and js-mode
GNU General Public License v3.0
181 stars 13 forks source link

correct library name on first and last line #111

Closed tarsius closed 8 years ago

tamzinblake commented 8 years ago

should modify lib/js3-foot.el and lib/js3-head.el

tarsius commented 8 years ago

This is confusing. Do you generate js3-mode.el from the files in lib?

tamzinblake commented 8 years ago

Yes. Update the files in lib and then run bin/build - the .el file is also committed to the repo just for legacy reasons.

tarsius commented 8 years ago

Okay, I have done that.

I have also fixed some other issues the byte-compiler told me about. (Addressing these issues was harder than doing so should have been because the byte-compiler told me about errors in js3-mode.el but I then had to determine the location inside one of the files in lib/ to actually fix it. Therefore I would strongly suggest you stop concatenating the "input libraries" to generate js3-mode.el -- "legacy reasons" doesn't seem like a good enough reason to make maintenance harder in the present and future.)

tamzinblake commented 8 years ago

:+1:

tarsius commented 8 years ago

Thanks for commit access, but I am not interested. I only came here to fix this issue because I noticed it as part of my work on the Emacsmirror. Please revoke commit access again.

tarsius commented 8 years ago

I still have commit access and have merged this now. Please remove my commit access - I don't want to do anymore but this.