Function indentation has a lousy compromise

[tamzinblake]

js3-consistent-level-indent-inner-bracket breaks a lot of intuitively good indentation, but it is preferred by some people because of the following two cases:

  var f3 = function () {
    foo()
  }

AND

  ;(function () {
    var a = 1
  })()

Ideally, those cases should just be handled correctly.

[tamzinblake]

The funny thing about the fix in 29d3a21 is that you'll have to re-indent everything if you add another function after the first in a var declaration. But that's better than anyone else's current solution for that, and who does that anyway?

[mbriggs]

Hey thom, I am still not getting correct indentation with immediately invoking functions, although I am from single var = functions. here is my indentation

;(function(){
    foo = 1
  }())

var foo = function(){
  foo = 1
}

I don't have any js3 vars set at this point other then global externs

[tamzinblake]

That's at the beginning of the buffer, right?

[mbriggs]

Yup, that was it :D add a newline at the start of the buffer and both work. Thanks so much for this man :)

[tamzinblake]

new version should fix that.