search

tamzinblake / js3-mode

A chimeric fork of js2-mode and js-mode
GNU General Public License v3.0
181 stars 13 forks source link

Provide the feature 'js3 so that (require 'js3) works correctly #89

Closed purcell closed 10 years ago

purcell commented 10 years ago

See https://github.com/milkypostman/melpa/commit/e5c2c6145119be5522127a98cdc640c59572956a#commitcomment-3999661 for an instance of the existing code causing problems.

At your option, you might consider also providing 'js3-mode, but I can't see this change causing any problems as-is.

-Steve

/cc @knu

swsnr commented 10 years ago

:+1: Currently, one cannot properly require js3 when installing from MELPA.

tamzinblake commented 10 years ago

Previously we soft-linked js3.el to js3-mode.el so that require would work with js3-mode.

We certainly don't want to stop providing js3-mode - that's what it's been called for years.

swsnr commented 10 years ago

@thomblake By convention, a file should always provide its file name. A soft link is no replacement, specifically not on systems that don't even support soft links (Windows).

purcell commented 10 years ago

@lunaryorn I've reverted the renaming of the MELPA package, so we're back to js3-mode now.

swsnr commented 10 years ago

@thomblake @purcell Thank you.