tananaev / passport-reader

e-Passport NFC Reader Android app
326 stars 126 forks source link

Option to pre-fill fields from intent and return image as base64 encoded string #13

Closed peterhorsley closed 5 years ago

peterhorsley commented 5 years ago

To provide even better integration, it's handy if this app can accept values in the intent for the passport number, date of birth and expiry date, so as to pre-fill those three fields, in case the calling app already has those values (e.g. as retrieved by scanning the passport MRZ value). This avoids the end user having to manually enter those values which leads to a better user experience.

One further improvement for integration is to include the passport photo as a base64 encoded string in the resulting intent, which enables cordova-based apps to read the image successfully.

Raising this issue to see if these are changes you would accept in this repo. I have already done the code for both the above changes and can raise a PR for you to review, if so :)

Thanks!

tananaev commented 5 years ago

Sure, feel free to send a pull request.

peterhorsley commented 5 years ago

@tananaev Thanks, raised a PR for that now.

peterhorsley commented 5 years ago

Fixed via PR #14