search

tananaev / passport-reader

e-Passport NFC Reader Android app
348 stars 132 forks source link

Update JMRTD library #18

Closed RomainL972 closed 4 years ago

RomainL972 commented 4 years ago

Hi, I noticed the version of the jmrtd library used in the app is quite old (it's from 2015) and when I try to read the passport I have received in December 2020, it doesn't work. It used to work with my old passport so I guessed there was some protocol change that made it incompatible. I then updated the app to use the latest version of jmrtd. Note: I also changed how the program replaces "<" with "" because it prints all the first names without separation

tananaev commented 4 years ago

Does it work now with both old and new passports? Also, what about the removed code?

RomainL972 commented 4 years ago

Yes it works with both old and new passports. I only removed code that wasn't used anywhere else or that isn't required with the new library version

tananaev commented 4 years ago

Merged, thanks.