search

tananaev / passport-reader

e-Passport NFC Reader Android app
326 stars 126 forks source link

Add build action #26

Closed RomainL972 closed 3 years ago

RomainL972 commented 3 years ago

This action will allow you to be sure that a commit compiles before uploading it to the play store for example. If it is from a pull request, you can make sure that the changes compile before accepting it, so you don't have a situation like https://github.com/tananaev/passport-reader/pull/24 again

tananaev commented 3 years ago

If the point is to check compilation, we should use different target. Also, I'm not sure what's the point of uploading files to transfer.sh.

RomainL972 commented 3 years ago

What do you mean by different target? For the uploading, it's if you want to download the produced APK to manually check it, but I can remove that part if you want.

tananaev commented 3 years ago

I'm trying to understand how official template works:

https://github.com/actions/starter-workflows/blob/main/ci/android.yml

How come it doesn't install SDK? Is it simply broken?

RomainL972 commented 3 years ago

I tested the official template and it works, I don't know how. However, the sample part doesn't work because super.onActivityResult isn't called.

RomainL972 commented 3 years ago

I changed main.yml so it doesn't run on pull requests, because it makes it fail since it can't commit.

RomainL972 commented 3 years ago

Pull request updated