search

tananaev / passport-reader

e-Passport NFC Reader Android app
326 stars 126 forks source link

Fix pace #27

Closed RomainL972 closed 3 years ago

RomainL972 commented 3 years ago

The changes from https://github.com/tananaev/passport-reader/pull/24 but with the import that allows the build to succeed

tananaev commented 3 years ago

@RomainL972 I get reports that this actually breaks decoding for some passports. Reverting it fixes the issue.

RomainL972 commented 3 years ago

I'll try to investigate, is there any information about which passports don't work?

tananaev commented 3 years ago

Austrian passport, but another one worked. Not sure. I also noticed that my Russian passport stopped working, even though it worked before. Not sure if it's related.

RomainL972 commented 3 years ago

Does it always happen, or only sometimes? It might just be a random reading error.

tananaev commented 3 years ago

For me it happens all the time, but again, I'm not sure it's the same issue. For the person who reported the issue with Austrian passport, I'm not sure. I asked him to reply here, but he hasn't yet.