search

tanansatpal / ngx-mat-intl-tel-input

MIT License
62 stars 114 forks source link

Compatibility with Angular 11 #86

Open pasblin opened 3 years ago

pasblin commented 3 years ago

hi, could you give it compatibility with angular 11?.

Regards.

emps commented 3 years ago

yes plz update this lib package for angular 11 so we will able to update angular 10 , 9 to 11

pasblin commented 3 years ago

Hi,

What is the status of this issue?

Is it planned to solve it in the short term?

Regards.

emps commented 3 years ago

i suggest untill this repo get updated , u can always uninstall this lib and then install back

npm uninstall ngx-mat-intl-tel-input git add . -A git commit -m "before ng update" ng update @angular/cli @angular/core npm install --save ngx-mat-intl-tel-input

jdespatis commented 3 years ago

I've updated my package to the 4.0.0 in order to have compatibility with Angular 11, but strangely, I keep on getting warnings during install:

npm WARN ngx-mat-intl-tel-input@4.0.0 requires a peer of @angular/common@~9.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN ngx-mat-intl-tel-input@4.0.0 requires a peer of @angular/core@~9.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN ngx-mat-intl-tel-input@4.0.0 requires a peer of @angular/forms@~9.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN ngx-mat-intl-tel-input@4.0.0 requires a peer of @angular/platform-browser@~9.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN ngx-mat-intl-tel-input@4.0.0 requires a peer of @angular/platform-browser-dynamic@~9.0.0 but none is installed. You must install peer dependencies yourself.

When I look in my node_modules/ngx-mat-intl-tel-input/package.json, I can still see references to Angular 9:

...
  "name": "ngx-mat-intl-tel-input",
  "peerDependencies": {
    "@angular/common": "~9.0.0",
    "@angular/core": "~9.0.0",
    "@angular/forms": "~9.0.0",
    "@angular/platform-browser": "~9.0.0",
    "@angular/platform-browser-dynamic": "~9.0.0",
    "libphonenumber-js": "^1.7.25"
  },
...

Any idea for those warnings ? problem when publishing this package ?

I've tried to remove completely my node_modules and install it back again, but still same problem

Thanks

pasblin commented 3 years ago

Not compatible with angular 11.1.0 yet?

nbaker82 commented 3 years ago

I pushed up a pull request to fix these issues.