search

tanaponpiti / google-search

0 stars 0 forks source link

Start of the code review process 👋 #17

Closed longnd closed 5 months ago

longnd commented 5 months ago

Hello Tanapon👋 , Thank you for your effort on the code submission. I am Long, engineering lead at Nimble, and I am happy to be the reviewer for our code review session.

During the review process, I would like to know more about your decisions, and thus I will create issues where I think there could be more improvements regarding your performance here.

At the same time, please keep in mind that this is a bi-directional process, and I would love to hear back from you as well. Therefore, do not hesitate to raise your questions or share your opinions about the implementation (if any) during the process.

If we are aligned on any issue, and you would like to correct them, please address the issue using a proper git flow (creating a new branch, opening a Pull Request (PR) per issue, and merging the code when you are ready), and I will follow up on those fixes. Please note that you don't have to close any of my created issues after merging your PRs, I will help verify and close them for you once they pass. 😇

We expect the code review process to be completed within 2-3 days at most. As a result, ensure you are responsive during this process. If you need additional time, please inform us right away so that we can plan accordingly.

In the end, I really do hope that you find the process enjoyable. Good luck and happy coding. 🤘

longnd commented 5 months ago

@tanaponpiti I have completed the initial round of code reviews focusing the most critical concerns to ensure we can keep the whole process within a few days. I am looking forward to hear your feedback on the open issues.

tanaponpiti commented 5 months ago

Hello Long, Thank you for reviewing my code. Hopefully my code is not being too rough, as I have very short amount of time to arrange things due to my current responsibility from day to day . I will try my best to cooperate with the review process as mush as possible.

longnd commented 5 months ago

@tanaponpiti I have replied to all of the issues. Please feel free to make any changes if you wish. Since we want to move quickly and I have enough understanding of your reasoning behind the chosen solutions, we can conclude this stage of the code review process. Thank you for your efforts thus far. Our TA team will provide feedback via email soon.