tanaylab / metacells-vignettes

Vignettes for the Python metacells package
https://tanaylab.github.io/metacells-vignettes/
1 stars 1 forks source link

Broken links for some plots in vignettes depending on the link #1

Open tzeitim opened 6 months ago

tzeitim commented 6 months ago

There are some images that seem to be rendered wrong depending on the url of the notebook. It seems that github has some inconsistencies in the relative paths (or something like that) depending on how notebooks are accessed.

For example, the iterative notebook accessed here:

https://tanaylab.github.io/metacells-vignettes/iterative.html

Is missing some of the figures (an example below).

The same notebook using a different (blob) url is well-rendered

https://github.com/tanaylab/metacells-vignettes/blob/main/notebooks/iterative.ipynb

The faulty links are the ones in the README so it's an easy fix to prevent users from reaching the faulty one.

Example:

For example, HBB is noisy, but is a clear erythrocytes marker, so it should not be lateral:

Has this url https://tanaylab.github.io/images/high-inner-fold.HBB.svg

The image can be found, however:

https://github.com/tanaylab/metacells-vignettes/blob/main/images/high-inner-fold.HBB.svg

tzeitim commented 6 months ago

Well, after spending more time working on the link that "works" I see that some images (e.g. color bars) are not rendering well there so it's one thing for another ...