tanaypratap / teamtanay.jobchallenge.dev

The web repository for all things #teamtanayjobchallenge
https://2020.teamtanay.jobchallenge.dev
132 stars 430 forks source link

[Project][feedback] multi user blog management system #235

Open cdking007 opened 4 years ago

cdking007 commented 4 years ago

hello sir,mentors kindly can you please review my project that i developed using nodejs

link demo: - http://ttjc-blog-managment-system.herokuapp.com/ link admin demo: - http://ttjc-blog-managment-system.herokuapp.com/admin github repo: - https://github.com/cdking007/ttjc-blog-managment-system

admin creditionals: demo/demo@007#

thank you :-)

cdking007 commented 4 years ago

no one commenting or giving feedback this is not good 😞

shrirambalaji commented 4 years ago

Hey @cdking007,

Good work on the blog management system. I was able to successfully signup, login and add a post.

Couple of suggestions on the UI: 1) The Cabin Sketch font you have used in the app doesnt seem to be imported into the css, hence the UI defaults to a serif font. Fonts are usually not a problem, but I'd suggest adding font-fallbacks. Since this is a blog website, readability is important, so consider using a sans-serif font.

2) Try using colors that are not too vibrant, and have better contrast. image For example, an aqua blue font isnt a good pick as textColor on a white background.

3) Email and password validation - Currently I am able to signup by giving an invalid email address text in the email field, say for eg. (ookok@gma). It would also be good to enforce a minimum password limit as well.

4) Better readability on the banner images - in the below image the text is not very readable. So consider using darker fonts, or maybe if you feel adventurous try adding an overlay layer on top of your image. image

5) Nitpick: Post cards of the same height image

6) Fix footer position - This a common css issue where the footer comes up when there isnt enough content. There are a couple of ways here to fix it :). image

I'll be adding more feedback after I find time to do a code review. Nevertheless, Kudos on the effort and Happy Coding! :smile:

cdking007 commented 4 years ago

ohk thank you so much sir i will fix this issues :-)