search

tanaypratap / teamtanay.jobchallenge.dev

The web repository for all things #teamtanayjobchallenge
https://2020.teamtanay.jobchallenge.dev
131 stars 429 forks source link

[project] [feedback] [code review] take a look at my project. #269

Open knowsach opened 4 years ago

knowsach commented 4 years ago

this website filters as per selected genres . I have used public movie apis to build this.

hosted link -> https://the-movie-mania.netlify.com/ github -> https://github.com/knowsach/movie-mania

please take a look at the source code and also suggest me features to add .

reeversedev commented 4 years ago

Hey! Your netlify link doesn't work. Can you please check?

NikhilNamal17 commented 4 years ago

Hey! Your netlify link doesn't work. Can you please check?

Try this link @reeversedev https://the-movie-mania.netlify.com/

knowsach commented 4 years ago

updated. please check.

reeversedev commented 4 years ago

Good job there!

I am mentioning some points here that I think can be sources of improvements though:

  1. The categories are right now in rectangles. Try to make them in square and show a poster of a movie related to it inside that box along with category name.
  2. While navigating to page https://the-movie-mania.netlify.com/movies, the top navigation bar can be improved in terms of spacing, just a bit margin here and there and it will improve the whole page itself. (You need to try some experiments)
  3. Try to remove the scroll bar that is coming because of overflow. (Don't just hide it, figure out why is it coming and try to adjust to page height) [HINT: It's because of the page height because of which page scroll is coming]
  4. This is more like a good-to-have feature but instead of having pagination, you can use infinite scrolling very easily here, because you are anyway going to make API requests and show the loader so make good use of it.

Keep in mind, these are just improvement points that I think can be done, but if you need any kind of help then reply here or you can reach me on twitter. (@reeversedev)