[Project][feedback]Please provide feedback on my Portfolio website

AbhinavReddy-Dev commented 4 years ago

I also created a pull request on contents/participants/ttjc@singularityDev, please check that as well. TIA...

ameerthehacker commented 4 years ago

Things that I loved

it is awesome to see that you have done such a wonderful job with hand rolled CSS in most cases
the website design is really good and the theme looks amazing
the meteor shower is super cool
I really loved the responsive mobile design
good thinking behind stopping the animations in the mobile devices (if that is what you intended)
the website looks really fun and professional at the same time

Images in some of the cards are overflowing
It would be a better UX if you can provide links to your multiple sections in the landing section itself
Try to add a favicon

I can see that there is no gitignore file and some junk files like .DS_Store has been checked in because of that
In multiple places there are lot of commented out code and I can understand during development happens but ensure before you submit it for final evaluation all those code are removed.
There is an unused js file in the project (not sure if it is needed in the future though)
In few places you have used inline styles, please try to replace them with classes if possible

Try to seperate out the external deps like animate.css into an npm module so that you don't check then into git
Try to provide a easy to development (eg. running a local web server which auto reloads whenever you make some changes), you can checkout https://www.npmjs.com/package/live-server

AbhinavReddy-Dev commented 4 years ago

Thanks a lot, that's some pretty detailed review for a portfolio website.

I did stop animations for mobile version as it was looking and feeling cluttered as if I was trying to showcase all my achievements, I really appreciate you for noticing it.
Yes, I do need to check with the image sizes in all screens and hope to clear that in a couple days.
I did provide links to sections on the left side of the screen, but I didn't make it available for Tablet and Mobile versions as we usually scroll through the content and the content is not so large that viewers would want an easy navigation. That .js file was for hamburger menu to make it available, maybe in the future.
animate.css is not an external dependency 😅, it contains meteor shower and other button animations I suppose.
Code cleanup is required though, I'll push that update soon. I'll check that inline styling and make it as a class.
Local web server is something I'm new to, I will try to integrate it as well.

Hope to push the code with all the above improvements at once. Once again, thanks for the clear review.

ameerthehacker commented 4 years ago

@singularityDev thanks for the clarifications, looking forward :)