search

tanaypratap / teamtanay.jobchallenge.dev

The web repository for all things #teamtanayjobchallenge
https://2020.teamtanay.jobchallenge.dev
131 stars 429 forks source link

[Portfolio and Project Feedback] #322

Open mvgk06 opened 4 years ago

mvgk06 commented 4 years ago

Hello Mentors,

  1. I would like my portfolio and project to be reviewed.

[Portfolio link] (https://ganeshkumar.netlify.com/) [Portfolio Git Hub link] (https://github.com/Ganesh-Kumar6/Portfolio)

[Project link] (https://ganeshkumar-recipebot.netlify.com/) [Project Git Hub link] (https://github.com/Ganesh-Kumar6/Recipe-Bot)

  1. How do I go about making changes to the main repo (teamtanay.jobchallenge.dev) ? Should I pull the changes made in this repo to my forked one, then push my updates and make a pull request ? or should I do something else. Please do guide me.

  2. Can I comment on other issues which are similar to mine so that mentors can review multiple projects from less number of issues ?

Thanks

tripsus commented 4 years ago

Hi Ganesh,

Good work on your portfolio. I have a few suggestions related to the UX

  1. Lets say I am in skills section their is no marker in header of that particular section which tells that I am in a particular section. Unless I see the html file in url or I see the content of page, I don't realize which section I am in.
  2. If I go to projects or skill section I see a vertical and horizontal scroll bar even if I am at 100% zoom. I think this needs to be fixed.
  3. I checked the recipe for a dosa and instructions section had no instruction "Check set dosa recipe instructions" is the actual output shown. I don't know if it is problem with the API or your implementation. You should double check it.
  4. Also the way ingredients and instructions are displayed, it seems more like this site is designed for mobile screens. You should leverage the large screen are we have in laptops/desktops.

P.S. I am not a UI developer, I was going through the list of projects here and stumbled across your project. So think of this feedback as end user feedback, you should in-corporate these changes mean while other UI folks will come and give you more detailed feedback.

mvgk06 commented 4 years ago

Thanks for the feed back will surely implement the suggested changes.

What about question 2 and 3 can you please answer those.

Thanks

tripsus commented 4 years ago

Sorry I didn't realize there were other two questions as well.

  1. Yes, you have to create a pull request. Clone this project -> create a branch and raise a pull request.
  2. That is a novel idea, but I am not sure about it. I will get back to you on this.
tripsus commented 4 years ago

As of now we are opting to comment/monitor each issues individually. We are planning to have a more streamlined process to allow participants to comment so, that it doesn't get randomized and we can track it easily. Thank you for lending a helping hand though :)

mvgk06 commented 4 years ago

Can you please check these links. I have updated both the projects as you suggested.

The updated project link https://ganeshkumar-recipebot.netlify.com/

Regarding the changes

  1. Initially I only used flex box to display recipes. Now I have used both grid and flex box so that I'm able to leverage the space in bigger screens.

  2. Also I have changed the way ingredients and instructions are displayed. I was able to improve the UI of that part which make things look nice than before.

  3. Regarding the set dosa data from API, I have double checked things it seems that some recipes don't have instructions or in rare cases also don't have proper images. So I displayed a message indicating the non availability of such instructions.

  4. I validated the apps and checked for all possible such issues. I think now everything is set :)

mvgk06 commented 4 years ago

The updated portfolio link https://ganeshkumar.netlify.com/

Regarding the changes

  1. Note that I have 2 portfolio now. This is the updated version.
  2. The navbar is finally fixed.