search

tanaypratap / teamtanay.jobchallenge.dev

The web repository for all things #teamtanayjobchallenge
https://2020.teamtanay.jobchallenge.dev
132 stars 429 forks source link

[project feedback] are you hungry ? this project can help you find something to eat. #328

Open knowsach opened 4 years ago

knowsach commented 4 years ago

I am using Zomato API to sort restaurants location wise.

website -> https://served.netlify.com/ github -> https://github.com/knowsach/served

itaditya commented 4 years ago

Good website, nice and simple.

Issues-

  1. If you directly open https://served.netlify.com/collection it will show 404. This is because there is no route registered on server for this. It works only on client side routing. Try this fix https://docs.netlify.com/routing/redirects/rewrites-proxies/#history-pushstate-and-single-page-apps
itaditya commented 4 years ago
  1. The background image doesn't mix with the 3 illustrations at the bottom. You can pick different colors on undraw to match with bg image. Also the illustrations don't server any purpose in a row.
image

The common pattern of using illustrations is to associate illustration with info like these-

image image
itaditya commented 4 years ago
  1. There should be a way to search again. Once user goes to /collections they have to click on browser back button to make another search. That is not the ideal UX. If you look at google.com for example they have a clean landing page just like yours, when user search it goes to to new page. But that page has a search bar as well
itaditya commented 4 years ago
  1. Centered single column cards waste a lot of space on desktop. It would be better if you utilize space on desktop much more by having a 3 column grid maybe.