tanaypratap / teamtanay.jobchallenge.dev

The web repository for all things #teamtanayjobchallenge
https://2020.teamtanay.jobchallenge.dev
132 stars 429 forks source link

[Project][Feedback]Feedback for portfolio #335

Open namancdr opened 4 years ago

namancdr commented 4 years ago

Hello to all the mentors, hope all of you are doing great.

i have created my portfolio website and looking forward for your feedback.

namancdr.netlify.com

profile pic is missing because i don't have a good picture of mine (lol),

pls have a look.

reeversedev commented 4 years ago

Hey Naman!

I'll be your reviewer for this portfolio.

First of all, congratulations for getting your portfolio ready and deployed. It's the hardest step and you accomplished that very well!

Now, I'd have given you some list of points but I think, your portfolio rather needs more guidance than correction. Don't worry, I'll help you out!

Let's complete it section by section.

Start with the first section of your name and picture. Get your photo uploaded first. Believe even a decent selfie also makes a lot of sense. Upload it and change your font-family to 'Nunito'.

namancdr commented 4 years ago

@reeversedev sir, made changes, you can check it out now. :-), & font is looking nice now

reeversedev commented 4 years ago

Yo @namancdr!

Changing fonts really brought the change. Kudos!

Let's combine the Header and About me section in a single section. I mean let's do it horizontally. Maybe you can wrap around a div which is flex based and get this touch up done?

For reference, I mean something like this.

One more thing, please don't refer me as 'Sir'. Just Prateek is fine. :)

namancdr commented 4 years ago

@reeversedev done,

but i moved my navbar to the top because of the mobile view. it will be placed wherever you say 😁.

& everything else is great you can check.

namancdr.netlify.com

reeversedev commented 4 years ago

How about removing the navbar?

Since, it's just a single page, I don't think we need navbar at all.

We'll see later. Try removing the navbar.

namancdr commented 4 years ago

@reeversedev removed navbar, what next? 😁

reeversedev commented 4 years ago

Awesome! Looks more convenient now.

How about removing the background image of code editor? And instead, you can use background color as black and background of 'My skills' as white?

Also, text-align:justify will make content inside paragraph tag more readable.

namancdr commented 4 years ago

@reeversedev then what will be the text color for my-skills ?

& don't i have to change the color of about me section ?

reeversedev commented 4 years ago

Do play around with it.

Even I am also not sure but I think white background will look more elegant.

namancdr commented 4 years ago

okay, let my try

tanaypratap commented 4 years ago

okay, let my try

I would suggest take inspiration from some prepared themes from designers. Search for one page themes and take the color combinations and fonts from there.

namancdr commented 4 years ago

okay, let my try

I would suggest take inspiration from some prepared themes from designers. Search for one page themes and take the color combinations and fonts from there.

OK

namancdr commented 4 years ago

@reeversedev changed the look completely, i think this one can be improved & will look more beautifull after improvements, pls have a look.

Namancdr.netlify.com

reeversedev commented 4 years ago

Two major things.

namancdr commented 4 years ago

@reeversedev done, have a look.

reeversedev commented 4 years ago

Great! Looks good to me.

Good for now. Build more projects, learn new things and write about it and share on your website.

We'll work on this more later.

namancdr commented 4 years ago

Ok 😁, thankyou so much ♥️