[Project][Feedback] Comfy_House - JS Shopping Cart App and Real Estate Website - Python/Django App

tanaypratap / teamtanay.jobchallenge.dev

The web repository for all things #teamtanayjobchallenge

https://2020.teamtanay.jobchallenge.dev

132 stars 430 forks source link

[Project][Feedback] Comfy_House - JS Shopping Cart App and Real Estate Website - Python/Django App #477

Open Shivraj97 opened 4 years ago

Shivraj97 commented 4 years ago

Hello maintainers. Please have a look at my two projects and do give your feedback.

1.Comfy_House - JS Shopping Cart App

It was build using HTML5/CSS3/JS
It is a simple e-commerce website with no backend.
The app was built using only vanilla.js and no other frontend frameworks were used. Live Demo - https://shivraj97.github.io/comfy_house

2.Real Estate Website - Python/Django App

It is fully functional property listing website with admin panel.
The admin can add property and realtors. The app supports user authentication(register and login) and also have a storage feature.
It was built using Python | Django | PostgreSQL | Bootstrap 4 | HTML5 | CSS3 Live Demo - realestatedjangoproject.herokuapp.com

tripsus commented 4 years ago

Hi @Shivraj97

Great work on the UI/UX part on both the projects. Both of the sites look really clean. Below are few of the things that I think can be imporved.

Comfy_House - JS Shopping Cart App

Shop now button does not work. I am not sure that what you intended when this button was added but I think we (atleast) can scroll to the products section when shop now is clicked.
Similarly for hamburger menu. It is there but does not do anything. We can get rid of it, if it is not rquired.

Real Estate Website - Python/Django App

In the About section View our featured listing is broken. You have deployed your app with DEBUG as true, we should not do that in production because if there is a crash then it will show the stack with some data to end user. Which is not good from security point of view.
Also you can handle 404 by giving a html page for it. Django has support for that.
Social media button is broken/not implemented.

Shivraj97 commented 4 years ago

Thanks for the review. I highly appreciate it. As for projects 1.Comfy_House - JS Shopping Cart App I will implemented scroll on shop now button. I intentionally left the hamburger button with no functionalities. I will remove it.

Real Estate Website - Python/Django App I have to left it TRUE because when I deployed it to heroku using FALSE it was not working. I have looked upon on internet for solutions but i couldn't figure it out. Hope you can help me in this regard. I intentionally left all social media links unattended because it was just a part of design since I don't have any social media handle for this imaginary real estate company.

Shivraj97 commented 4 years ago

I have added the scroll and removed hamburger menu in Comfy_House app but I cannot add Custom 404 page with DEBUG=True in production and I cannot make DEBUG=False otherwise site doesn't load. I am completely stuck.

Shivraj97 commented 4 years ago

I have added custom 404 and 500 page and it works completely fine with DEBUG = False in development mode but it doesn't work in production with DEBUG = True and i can't make it False otherwise the entire app doesn't load.

tripsus commented 4 years ago

Can you please share the link to your code?

Shivraj97 commented 4 years ago

Github Link https://github.com/Shivraj97/real_estate_django_project

I have fixed that view our featured listings link.